Allow Int64 values within IO#read_at
#10356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oh, I would have thought they would have been upcasted... |
|
We'll' need overloads to accept at least |
Yeah, I would have liked that too... |
Add overload to accept Int32s
|
@straight-shoota Fixed in latest commit. @asterite Yea that feature would have been perfect here. No reason not to do that that I can think of. |
asterite
reviewed
Feb 3, 2021
bcardiff
approved these changes
Feb 4, 2021
straight-shoota
approved these changes
Feb 4, 2021
|
Checking, why is this PR a breacking-change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10032.
The C bindings have this arg typed as
SizeT, which from what I know is an unsigned int. Do we need to worry/do anything about the case where an Int64 is passed on a 32bit system where a sufficiently large enough Int64 would overflow a UInt32?